[codex] Prehash resolver path dependencies#206
Draft
hardfist wants to merge 4 commits into
Draft
Conversation
Merging this PR will degrade performance by 12.19%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | resolver[multi-thread] |
11 MB | 12.4 MB | -11.32% |
| ❌ | Memory | resolver[resolve from symlinks] |
12 MB | 14.1 MB | -14.65% |
| ❌ | Memory | resolver[[single-threaded]resolve with many extensions] |
12.8 MB | 14.3 MB | -10.53% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/prehash-path-dependencies (4eb983f) with main (8975e38)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathDependencyandResolvePreHashedContextso callers can consume resolver dependency paths with their precomputed path hash.package.jsonpath so repeated package-json lookups and dependency recording can reuse the joined path.Why
Rspack
build_module_graphpath dependency handling currently hashes dependency paths in the resolver context and then hashes the same paths again when converting them into Rspack prehashedArcPathsets. This API lets Rspack reuse the resolver-side hash instead of paying for another fullPathhash during that conversion.Validation
cargo fmt --checkcargo checkcargo test tests::dependencies --libcargo clippy --lib -- -D warningscargo test package_jsoncargo testwas also attempted earlier; 124 tests passed and 6 existing PnP fixture tests failed withNotFound(...), which appears unrelated to this change.